Fix Direct Line Speech null attachments and update test snapshots#3154
Merged
compulim merged 4 commits intomicrosoft:masterfrom May 12, 2020
Merged
Fix Direct Line Speech null attachments and update test snapshots#3154compulim merged 4 commits intomicrosoft:masterfrom
compulim merged 4 commits intomicrosoft:masterfrom
Conversation
compulim
requested review from
a-b-r-o-w-n,
beyackle,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
tdurnford
approved these changes
May 11, 2020
compulim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Fixed
Description
Few changes:
attachmentsandsuggestedActionsto benullinstead ofundefined(not able to default)textfield whenspeakfield is not set (from bot)Specific Changes
incomingActivitySaga.js