Keep props.locale when sending to bot#3095
Merged
compulim merged 6 commits intomicrosoft:masterfrom Apr 10, 2020
Merged
Conversation
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
corinagum
reviewed
Apr 9, 2020
corinagum
approved these changes
Apr 9, 2020
compulim
added a commit
that referenced
this pull request
Apr 10, 2020
* Keep props.locale when sending to bot * Add entry * Clean up * Update docs/HOOKS.md Co-Authored-By: Corina <[email protected]> * Fix tests Co-authored-by: Corina <[email protected]>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
props.localewhen sending to the bot, by @compulim in PR #3095Description
If the dev set
props.localetoen-HK, we should send this to the bot without modifications.Today, since
en-HKis not in the localization database, we normalize it toenand send it to the bot. We should only use the normalized form when we need it, e.g. date/unit formatting.Normalizing means, we change it from an unknown string, into something closest in our database with our best effort.
Specific Changes
Composernot to normalize the locale foruseLanguageand Web Chat CoreComposerto do the normalization for:globalize)