Selectable audio input device#3079
Merged
compulim merged 36 commits intomicrosoft:masterfrom Apr 22, 2020
Merged
Conversation
ad620e4 to
530c1f3
Compare
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
corinagum
suggested changes
Apr 6, 2020
Contributor
corinagum
left a comment
There was a problem hiding this comment.
To discuss:
- number of packages published for this project that aren't peer reviewed
- how complicated our single-page samples have gotten. They need to be simpler and split into re-used modules
Contributor
Author
|
Tests for Direct Line Speech added. Test is currently failing due to reliability, will fix it. |
corinagum
reviewed
Apr 9, 2020
corinagum
reviewed
Apr 9, 2020
Co-Authored-By: Corina <[email protected]>
Co-Authored-By: Corina <[email protected]>
b21d54b to
5288298
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
Fixed
Changed
microsoft-cognitiveservices-speech-sdkto reduce footprint, by @compulim in PR #3079Samples
Description
Support selectable audio input device. From user report, even AirPod is connected, on iOS, it is not selected as default. JavaScript is required to select the device and make it default.
Also, today, we have 3 references of
microsoft-cognitiveservices-speech-sdk, which take up significantly amount of size in our bundle (~300 KB each). We are going to converge them into a single copy inside the bundle.We will temporarily bump to a preview build of
web-speech-cognitive-services. When we do production release, we will build a production version ofweb-speech-cognitive-servicesand bump the version in Web Chat.Specific Changes
webpack.config.jsto reference to the samemicrosoft-cognitiveservices-speech-sdkpackage to reduce footprint by ~600 KBaudioContextoption tocreateCognitiveServicesSpeechServicesPonyfillFactory()audioContextobjectaudioInputDeviceIdoption tocreateCognitiveServicesSpeechServicesPonyfillFactory()audioConfigis set, we will useaudioInputDeviceIdto select the correct audio input devicepostinstallscript to transpile them afternpm run bootstraporlerna add. We prefer to usepostinstallbecause build time is substantial and to reduce the tax on our build@babel/plugin-proposal-async-generation-functionsevent-iteratormicrosoft-cognitiveservices-speech-sdkreact-sayto not breaking IE11External changes