Internationalization: Fix loading JSON files#2949
Merged
compulim merged 6 commits intomicrosoft:masterfrom Feb 27, 2020
Merged
Conversation
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
Contributor
Author
|
@corinagum can you verify if |
corinagum
reviewed
Feb 27, 2020
corinagum
approved these changes
Feb 27, 2020
Contributor
corinagum
left a comment
corinagum
left a comment
There was a problem hiding this comment.
Approved pending 1 fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Description
Localization team use different JSON file names than Unicode standard. And we missed cleaning up, and got a bad naming.
Specific Changes
Added tests to make sure the language code match the content of JSON files.
Localization team use different JSON file names than Unicode standard:
sr-Cyrl-CS.jsonforsr-Cyrlsr-Latn-CS.jsonforsr-Latnzh-CNforzh-Hanszh-HKforzh-Hant-HKzh-TWforzh-HantAlso, we have naming bugs:
sl-SLshould besl-SIAnd we have a bogus file:
he-IL.jsshould be removed, usehe-IL.jsoninsteadThe following language should default to RTL:
ar-SA