New message indicator only show up for new messages#2915
Merged
compulim merged 10 commits intomicrosoft:masterfrom Feb 19, 2020
Merged
New message indicator only show up for new messages#2915compulim merged 10 commits intomicrosoft:masterfrom
compulim merged 10 commits intomicrosoft:masterfrom
Conversation
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
corinagum
reviewed
Feb 18, 2020
corinagum
reviewed
Feb 18, 2020
corinagum
approved these changes
Feb 18, 2020
Contributor
corinagum
left a comment
corinagum
left a comment
There was a problem hiding this comment.
Approved, pending rebase and a couple of comments.
compulim
force-pushed
the
feat-new-message
branch
from
b46e9b3 to
a1f4341
Compare
compulim
force-pushed
the
feat-new-message
branch
from
a1f4341 to
b7b4b7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Description
When the user scroll up, the new message indicator will not show up until a new message activity is received.
Specific Changes
ScrollToEndButton.jsread ID)