Skip to content

Customizing typing indicator#2912

Merged
compulim merged 17 commits intomicrosoft:masterfrom
compulim:feat-custom-typing-indicator
Feb 20, 2020
Merged

Customizing typing indicator#2912
compulim merged 17 commits intomicrosoft:masterfrom
compulim:feat-custom-typing-indicator

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Feb 17, 2020

Fixes #2213.

Changelog Entry

Breaking changes

  • Customizable typing indicator: data and hook related to typing indicator are being revamped in PR #2912
    • lastTypingAt reducer is deprecated, use typing instead. The newer reducer contains typing indicator from the user
    • useLastTypingAt() hook is deprecated, use useActiveTyping(duration?: number) instead. For all typing information, pass Infinity to duration argument

Added

Samples

Description

This work will enable developers to customize the typing indicator. Also allow the developers to show the typing indicator for the user, in additional to the bot.

Specific Changes

  • API and data
    • Added new useActiveTyping hook
      • For listing participants (bot + user) who are actively typing
      • Optionally, developer can pass the timeout for inactivity
    • Added new typing reducer
    • Deprecated typingAt reducer and useLastTypingAt hook
    • Added useRenderTypingIndicator hook
  • UI
    • <BasicWebChat>: Added typingIndicatorMiddleware prop
    • <Composer>: Added typingIndicatorRenderer prop
  • Sample
    • Added a new sample
      • Override typing indicator to show typing activity from the user side, as well as from the bot side

To-do


  • Testing Added

@compulim compulim changed the title [DRAFT] Customizing typing indicator Customizing typing indicator Feb 17, 2020
@compulim compulim marked this pull request as ready for review February 17, 2020 07:52
@tdurnford tdurnford self-assigned this Feb 18, 2020
@compulim compulim force-pushed the feat-custom-typing-indicator branch from f62adb5 to c6e5bc0 Compare February 19, 2020 22:29
Comment thread docs/HOOKS.md Outdated
Comment thread docs/HOOKS.md Outdated
Comment thread docs/HOOKS.md Outdated
Comment thread docs/HOOKS.md Outdated
Comment thread docs/HOOKS.md Outdated
Comment thread packages/core/src/reducer.ts Outdated
Comment thread packages/core/src/reducers/lastTypingAt.js
Comment thread CHANGELOG.md
@compulim compulim merged commit 2172870 into microsoft:master Feb 20, 2020
@compulim compulim mentioned this pull request Mar 5, 2020
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[IC3] Customizing bot's typing indicator

3 participants