Show download link and icon based on contentUrl#2868
Merged
compulim merged 10 commits intomicrosoft:masterfrom Feb 6, 2020
Merged
Show download link and icon based on contentUrl#2868compulim merged 10 commits intomicrosoft:masterfrom
contentUrl#2868compulim merged 10 commits intomicrosoft:masterfrom
Conversation
compulim
changed the title
contentUrlcontentUrl
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
compulim
changed the title
contentUrlcontentUrl
tdurnford
reviewed
Feb 4, 2020
tdurnford
reviewed
Feb 4, 2020
tdurnford
reviewed
Feb 4, 2020
tdurnford
approved these changes
Feb 4, 2020
Co-Authored-By: TJ Durnford <[email protected]>
compulim
force-pushed
the
feat-file-content
branch
from
0b69a51 to
68d53ba
Compare
Contributor
Author
|
Thanks @tdurnford for reviewing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
DownloadAttachmentandUploadAttachmentwithFileAttachment, which show download link and icon if the attachment containscontentUrl, by @compulim in PR #XXXDescription
Today, we assume the channel do not allow end-user to download the file they uploaded. This assumption is not valid for channels other than Direct Line.
We should use
activity.attachments[].contentUrlto determine whether the file can be downloaded or not.Specific Changes
contentUrlblob:, it should not be downloadable<DownloadAttachment>and<UploadAttachment>with<FileAttachment>, which will determine if the download link and icon should be shown or not, based oncontentUrlis truthy or not<FileContent>similar to other components, e.g.<AudioContent>,<TextContent>,<VideoContent>, etc