Support replace activity with same ID#2825
Merged
corinagum merged 5 commits intomicrosoft:masterfrom Jan 17, 2020
Merged
Conversation
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
tdurnford
reviewed
Jan 17, 2020
tdurnford
approved these changes
Jan 17, 2020
Co-Authored-By: TJ Durnford <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
Description
When the chat adapter (DirectLineJS) send us an activity with non-empty ID which already exists in Web Chat, we will replace the on-screen activity with the latest version.
Specific Changes
activities.jsreducer to handle duplicate non-empty IDs