Fix deprecation upgrade code for speech credentials#2824
Merged
corinagum merged 7 commits intomicrosoft:masterfrom Jan 17, 2020
Merged
Fix deprecation upgrade code for speech credentials#2824corinagum merged 7 commits intomicrosoft:masterfrom
corinagum merged 7 commits intomicrosoft:masterfrom
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
credentialsshould returnauthorizationTokenandsubscriptionKeyas string and allow empty LUIS reference grammar ID, by @compulim in PR #2824Description
The change introduced in #2759 has a deprecation upgrade code. But the deprecation upgrade code was broken.
The deprecation upgrade code should turns authorization token and subscription key, into the format of
credentials = async () => ({ authorizationToken: '...', region: 'westus2' })(orsubscriptionKey).The deprecation upgrade code should handle these types of authorization token and subscription key:
This PR also update to use
.eslintignore.Specific Changes
createCognitiveServicesSpeechServicesPonyfillFactory.jscredentialsso that it will return a() => Promise<{ authorizationToken: string, region: string }>luis/undefined-PRODUCTION.eslintignore