Skip to content

Bumped react film and set flippers to blur on click #2801

Merged
corinagum merged 17 commits intomicrosoft:masterfrom
tdurnford:react-film
Jan 15, 2020
Merged

Bumped react film and set flippers to blur on click #2801
corinagum merged 17 commits intomicrosoft:masterfrom
tdurnford:react-film

Conversation

@tdurnford
Copy link
Copy Markdown
Contributor

Fixes #1673

Changelog Entry

Description

Bumped react film to the most recent master release, and configured suggested action and carousel flippers to blur on click.

  • Testing Added

Comment thread packages/component/src/Activity/CarouselLayout.js Outdated
@compulim
Copy link
Copy Markdown
Contributor

Looks like bumping to [email protected] fixed the problem.

But I am not able to kickoff a build based on your branch, could you take a look?

@corinagum corinagum merged commit c662c56 into microsoft:master Jan 15, 2020
@corinagum
Copy link
Copy Markdown
Contributor

@marq47
Copy link
Copy Markdown

marq47 commented Jan 20, 2020

Hi, there would be some way to customize in WebChat the carousel/suggested actions flipper behaviour changing react-film properties like autoHide (we need this property will be false), dir, showScrollBar, autoCenter, flipperBlurFocusOnClick, etc?

Now with styleSet we can only customize colors with Transcript overlay buttons properties (transcriptOverlayButtonBackground, transcriptOverlayButtonBackgroundOnFocus, transcriptOverlayButtonBackgroundOnHover, etc).

Thank you very much for your attention!!

@tdurnford
Copy link
Copy Markdown
Contributor Author

@marq47 can you open a new feature request and add details on what you would like to see changed. This thread isn’t going to get much attention since the PR has already been merged.

@compulim compulim mentioned this pull request Mar 5, 2020
40 tasks
@vasnakos
Copy link
Copy Markdown

Hi, there would be some way to customize in WebChat the carousel/suggested actions flipper behaviour changing react-film properties like autoHide (we need this property will be false), dir, showScrollBar, autoCenter, flipperBlurFocusOnClick, etc?

Now with styleSet we can only customize colors with Transcript overlay buttons properties (transcriptOverlayButtonBackground, transcriptOverlayButtonBackgroundOnFocus, transcriptOverlayButtonBackgroundOnHover, etc).

Thank you very much for your attention!!

Its been 5 years from that comment but as I need to customize the carousel of cards, Is there any progress been made on that request?
CC @compulim @marq47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggested actions navigation arrows should indicate focus visually

5 participants