Skip to content

Update CroppedImage PropTypes#2795

Merged
tdurnford merged 2 commits intomicrosoft:masterfrom
tdurnford:2647
Jan 3, 2020
Merged

Update CroppedImage PropTypes#2795
tdurnford merged 2 commits intomicrosoft:masterfrom
tdurnford:2647

Conversation

@tdurnford
Copy link
Copy Markdown
Contributor

Fixes #2647

Changelog Entry

Fixes #2647. Update the CroppedImage component PropType, by @tdurnford in PR #27XX

Description

Updated CroppedImage.propType.height to include strings.


  • Testing Added

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 3, 2020

Coverage Status

Coverage remained the same at 65.915% when pulling 2812e51 on tdurnford:2647 into 7946bde on microsoft:master.

Copy link
Copy Markdown
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tdurnford tdurnford merged commit f9f9d6f into microsoft:master Jan 3, 2020
@compulim compulim mentioned this pull request Mar 5, 2020
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning on react prop height of type string supplied to CroppedImage

3 participants