Moved Timestamp into SendStatus component#2786
Merged
corinagum merged 6 commits intomicrosoft:masterfrom Jan 4, 2020
Merged
Conversation
tdurnford
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
corinagum
approved these changes
Jan 4, 2020
Contributor
corinagum
left a comment
corinagum
left a comment
There was a problem hiding this comment.
Cool stuff, I like how much it cleans up the code. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2747
Changelog Entry
Fixes #2747. Moved
Timestampinto theSendStatuscomponent and removed theTimestampstyle set, by @tdurnford in PR #2786Description
Moved the
TimeStampcomponent from theStackedLayoutandCarousalLayoutcomponents to theSendStatuscomponent reducing redundant code across the layouts.Additional Context
Simplifies code changes for #2722