Skip to content

Improve test reliability#2777

Merged
compulim merged 16 commits intomicrosoft:masterfrom
compulim:feat-test-reliability
Dec 29, 2019
Merged

Improve test reliability#2777
compulim merged 16 commits intomicrosoft:masterfrom
compulim:feat-test-reliability

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Dec 27, 2019

Fixes #2612. Fixes #2653. Fixes #2691. Fixes #2737. Fixes #2776. Fixes #2483.

Changelog Entry

Fixed

  • Fixes the following issues and improves test reliability, by @compulim in PR #XXX
    • Fixes #2612. Wait until language change
    • Fixes #2653. Scroll-to-bottom check will do 5 consecutive checks to determine stickiness.
    • Fixes #2691. Wait until button is shown/hid before taking screenshot
    • Fixes #2737. Use driver.wait for conditions
    • Fixes #2776. Wait until button is shown/hid before taking screenshot
    • Use global timeout values

Description

Improve test reliability.

Specific Changes

See CHANGELOG.md for details.


  • Testing Added

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 27, 2019

Coverage Status

Coverage remained the same at 65.915% when pulling 2ed6c3e on compulim:feat-test-reliability into 31c2006 on microsoft:master.

Comment thread __tests__/setup/conditions/negate.js Outdated
Comment thread __tests__/setup/conditions/scrollToBottomCompleted.js Outdated
Copy link
Copy Markdown
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please check out my comments before merging in. What do you think?

@compulim compulim merged commit 3c78937 into microsoft:master Dec 29, 2019
@compulim compulim deleted the feat-test-reliability branch December 29, 2019 20:34
@compulim compulim mentioned this pull request Mar 5, 2020
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants