Skip to content

Use ES5 versions of non-ES5 bundles#2774

Merged
compulim merged 2 commits intomicrosoft:masterfrom
compulim:feat-es5
Dec 27, 2019
Merged

Use ES5 versions of non-ES5 bundles#2774
compulim merged 2 commits intomicrosoft:masterfrom
compulim:feat-es5

Conversation

@compulim
Copy link
Copy Markdown
Contributor

Fixes #2773.

Changelog Entry

Fixes

Description

Use ES5-pre-transpiled version of packages that did not offer ES5 modules.

Specific Changes

  • component: Use event-target-shim-es5
  • directlinespeech-sdk: Use abort-controller-es5, event-target-shim-es5 and p-defer-es5

  • Testing Added
    • Existing tests should cover the change

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+4.8%) to 65.915% when pulling df4741e on compulim:feat-es5 into 6c664a9 on microsoft:master.

Copy link
Copy Markdown
Contributor

@tdurnford tdurnford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green light

@compulim compulim merged commit 99b6892 into microsoft:master Dec 27, 2019
@compulim compulim deleted the feat-es5 branch December 27, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use ES5 version of non-ES5 modules

3 participants