#2641 Reorganize samples#2762
Merged
corinagum merged 68 commits intomicrosoft:masterfrom Jan 3, 2020
Merged
Conversation
corinagum
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
tdurnford
reviewed
Dec 18, 2019
stevengum
reviewed
Dec 29, 2019
|
|
||
| return mapped; | ||
| }, [array, mapper, nextMapperCalls]); | ||
| }, [array, mapper, nextMapperCalls, prevMapperCalls]); |
Contributor
Author
There was a problem hiding this comment.
via npm run eslint
|
|
||
| - Fork this repository | ||
| - Navigate to `/Your-Local-WebChat/samples/01.c.getting-started-migration` in command line | ||
| - Navigate to `/Your-Local-WebChat/samples/00.migration/a.v3-to-v4` in command line |
Member
There was a problem hiding this comment.
There are plans to add additional migration samples, hence the current sample structure for 00.migration/.
(Only one v3-to-v4 sample exists).
corinagum
commented
Dec 31, 2019
| "babel-jest": "^24.9.0", | ||
| "core-js": "^3.5.0", | ||
| "coveralls": "^3.0.9", | ||
| "eslint-plugin-react": "^7.17.0", |
Contributor
Author
There was a problem hiding this comment.
I am not sure what I did, but I needed to reinstall this package while working on this PR
corinagum
commented
Dec 31, 2019
| | [`23.a.hybrid-react-npm`](https://github.com/microsoft/BotFramework-WebChat/tree/master/samples/23.a.hybrid-react-npm) | Demonstrates how to use different versions of React on a hosting app via NPM packages | [Hybrid React Demo](https://microsoft.github.io/BotFramework-WebChat/23.a.hybrid-react-npm) | | ||
| | Sample Name | Description | Link | | ||
| | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | **Migration** | | | |
Contributor
Author
There was a problem hiding this comment.
I know it's not ideal, but I intentionally did not add another column for directory groupings because it would severely limit the real estate available for listing the descriptions and sample names. If you have a better suggestion, please feel free.
We can also iterate on this table after this major sample is merged in.
corinagum
commented
Dec 31, 2019
| @@ -0,0 +1,50 @@ | |||
| pool: | |||
Contributor
Author
There was a problem hiding this comment.
The .yml files were marked by git as deleted (and the new one added), as opposed to renamed. I'm assuming this is because there was a significant enough change to the file to consider it a new file.
tdurnford
reviewed
Jan 3, 2020
tdurnford
reviewed
Jan 3, 2020
tdurnford
reviewed
Jan 3, 2020
tdurnford
reviewed
Jan 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2641
Changelog Entry
Samples NOT tested:
The rest of the samples have been tested locally and work fine. Manual testing of samples after merge will be completed asap by me (this includes manual testing of hyperlinks to the samples)
@tdurnford and @compulim, sorry in advance that there are so many file changes. I got @stevengum to do an initial pass and he left some comments on questions we discussed in person.
Description
This is a rework of the samples directory. Overall structure has been discussed internally. Here are the new groupings:
00.migration01.getting-started02.branding-styling-and-customization03.speech04.api(intentionally left lowercase to match naming convention of other samples, e.g. ui instead of UI)05.custom-components06.recomposing-ui07.advanced-web-chat-appsSpecific Changes
See below for screencaps of the new directory
Testing Added