Moved core-js from devDeps to deps in directlinespeech-sdk package.#2727
Merged
Moved core-js from devDeps to deps in directlinespeech-sdk package.#2727
Conversation
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten and
tdurnford
as code owners
corinagum
approved these changes
Dec 13, 2019
73 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Moved
core-jsfrom dev dependencies to dependencies inbotframework-directlinespeech-sdkpackage, by @tonyanziano, in PR #2727Description
botframework-directlinespeech-sdkpackage depends oncore-js/features/observablebut listscore-jsas a dev dependency when it needs to be a production dependency so that it is installed properly when imported as a dependency.Specific Changes
changed
core-jsfrom devDeps to deps inpackages/directlinespeech