Skip to content

Add Object.is polyfill#2719

Merged
compulim merged 1 commit intomicrosoft:masterfrom
compulim:fix-2718
Dec 12, 2019
Merged

Add Object.is polyfill#2719
compulim merged 1 commit intomicrosoft:masterfrom
compulim:fix-2718

Conversation

@compulim
Copy link
Copy Markdown
Contributor

Fixes #2718.

Changelog Entry

Fixed

Description

Usage of Object.is was added in #2710 but the polyfill for ES5 browsers was not added.

Specific Changes

  • Add corejs/features/object/is to ES5 bundle

  • Testing Added
    • Manual test steps
    1. Load ES5 bundle in IE11, the UI should show up

@compulim compulim mentioned this pull request Dec 12, 2019
73 tasks
@compulim compulim changed the title Add Object.is Add Object.is polyfill Dec 12, 2019
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 61.108% when pulling 89f814e on compulim:fix-2718 into 9e43da0 on microsoft:master.

Copy link
Copy Markdown
Contributor

@tdurnford tdurnford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compulim compulim merged commit 7d67f26 into microsoft:master Dec 12, 2019
@compulim compulim deleted the fix-2718 branch December 12, 2019 17:42
@corinagum corinagum mentioned this pull request Dec 13, 2019
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ES5 bundle should load Object.is polyfill

3 participants