Skip to content

#2658 Fix rendering of markdown images in IE11#2659

Merged
corinagum merged 7 commits intomicrosoft:masterfrom
corinagum:2658
Dec 3, 2019
Merged

#2658 Fix rendering of markdown images in IE11#2659
corinagum merged 7 commits intomicrosoft:masterfrom
corinagum:2658

Conversation

@corinagum
Copy link
Copy Markdown
Contributor

@corinagum corinagum commented Dec 3, 2019

Fixes #2658

Changelog Entry

Description

Before (IE11):
image

After (IE11):
image

Specific Changes


  • Testing Added

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 3, 2019

Coverage Status

Coverage remained the same at 63.696% when pulling 6938257 on corinagum:2658 into 08563a9 on microsoft:master.

Copy link
Copy Markdown
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think our MockBot receipt card have very similar problem. Since this is scoped to Markdown, it won't fix it.

Let's fix this one first and we add a new issue to verify all activities are handling "large" image in IE11 correctly.

Comment thread packages/component/src/Styles/StyleSet/TextContent.js Outdated
@corinagum
Copy link
Copy Markdown
Contributor Author

@compulim I added it to our MockBot update issue: #2657

@corinagum corinagum merged commit 0fcd7fe into microsoft:master Dec 3, 2019
@corinagum corinagum mentioned this pull request Dec 13, 2019
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IE11 does not respect max-width of markdown images

3 participants