Adds AdaptiveCardsComposer and AdaptiveCardsContext for composability#2648
Merged
compulim merged 8 commits intomicrosoft:masterfrom Dec 2, 2019
Merged
Adds AdaptiveCardsComposer and AdaptiveCardsContext for composability#2648compulim merged 8 commits intomicrosoft:masterfrom
compulim merged 8 commits intomicrosoft:masterfrom
Conversation
tdurnford
reviewed
Dec 2, 2019
tdurnford
reviewed
Dec 2, 2019
corinagum
reviewed
Dec 2, 2019
Co-Authored-By: TJ Durnford <[email protected]>
73 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
AdaptiveCardsComposerandAdaptiveCardsContextfor composability for Adaptive Cards, by @compulim, in PR #2648Description
Today, we support UI recomposition, but not with Adaptive Cards. This is because we only expose a minimal
<Composer>but not a full version which include Adaptive Cards support.This PR will add UI composability for activities with Adaptive Cards. This is required for our "Smart Display" sample, which will be submitted later.
Goal: we will add a new
<Composer>with enhancements specific for Adaptive Cards.Specific Changes
AdaptiveCardsComposerandAdaptiveCardsContext, which store Adaptive Cards specific contentComposerwithFullComposer, which enhance by adding Adaptive Cards specific content, and load additional style set dedicated for Adaptive CardscreateStyleSetwithcreateFullStyleSet, which enhance by adding Adaptive Cards specific stylesdefaultPropsandpropTypesfrom minimalComposerandBasicWebChatrenderMarkdowntoundefinedinstead oftext => text