Make Suggested Actions accessible again!#2613
Merged
corinagum merged 14 commits intomicrosoft:masterfrom Nov 20, 2019
Merged
Conversation
…to 1780-suggestedActionsA11y
tdurnford
reviewed
Nov 20, 2019
tdurnford
reviewed
Nov 20, 2019
tdurnford
reviewed
Nov 20, 2019
tdurnford
reviewed
Nov 20, 2019
compulim
approved these changes
Nov 20, 2019
Contributor
compulim
left a comment
There was a problem hiding this comment.
Automatic approve if everything commented is fixed.
tdurnford
reviewed
Nov 20, 2019
tdurnford
reviewed
Nov 20, 2019
tdurnford
reviewed
Nov 20, 2019
tdurnford
reviewed
Nov 20, 2019
tdurnford
reviewed
Nov 20, 2019
tdurnford
reviewed
Nov 20, 2019
Co-Authored-By: William Wong <[email protected]>
Co-Authored-By: William Wong <[email protected]>
73 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(jk they were never accessible)
Fixes #1780
Fixes #2277
Fixes #2285
Changelog Entry
Note: How to test Suggested Actions container on Mock Bot
emptycardorsuggested-actionsDescription
aria-live=" "andaria-hidden={true}inside the Carousel componenten-usfor changes.Browser discrepancies
Previously, Suggested Actions were ignored by the AT. This PR fixes that, HOWEVER, there are some idiosyncrasies across browsers that are documented below: