Skip to content

Add React Hooks for customization (part 8)#2549

Merged
corinagum merged 4 commits intomicrosoft:masterfrom
compulim:feat-redux-hooks-8
Nov 21, 2019
Merged

Add React Hooks for customization (part 8)#2549
corinagum merged 4 commits intomicrosoft:masterfrom
compulim:feat-redux-hooks-8

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Nov 4, 2019

Related to #2539.

Please merge #2540, #2541, #2542, #2543, #2544, #2547 and #2548 before reviewing this one.

Changelog Entry

  • Resolves #2539, added React hooks for customization, by @compulim, in the following PRs:
    • PR #2540: useActivities, useReferenceGrammarID, useSendBoxDictationStarted
    • PR #2541: useStyleOptions, useStyleSet
    • PR #2542: useLanguage, useLocalize, useLocalizeDate
    • PR #2543: useAdaptiveCardsHostConfig, useAdaptiveCardsPackage, useRenderMarkdownAsHTML
    • PR #2544: useAvatarForBot, useAvatarForUser
    • PR #2547: useEmitTypingIndicator, usePeformCardAction, usePostActivity, useSendEvent, useSendFiles, useSendMessage, useSendMessageBack, useSendPostBack
    • PR #2548: useDisabled
    • PR #2549: useSuggestedActions

Description

Add several post message related hooks:

  • useSuggestedActions

Specific Changes

  • Added the following hooks:
    • useSuggestedActions
  • Updated components to use aforementioned hooks

  • Testing Added

@compulim compulim force-pushed the feat-redux-hooks-8 branch 2 times, most recently from dc44c58 to f070944 Compare November 4, 2019 01:07
@compulim compulim force-pushed the feat-redux-hooks-8 branch 2 times, most recently from 5c9e8c0 to 2339bf2 Compare November 4, 2019 01:55
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 4, 2019

Coverage Status

Coverage decreased (-0.008%) to 64.04% when pulling 747a923 on compulim:feat-redux-hooks-8 into a2bb227 on microsoft:master.


jest.setTimeout(timeouts.test);

test('getter should get suggested actions', async () => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a test for setting suggested actions?

Copy link
Copy Markdown
Contributor

@tdurnford tdurnford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corinagum
Copy link
Copy Markdown
Contributor

@compulim this has eslint errors. Please fix.

@corinagum corinagum merged commit 7e00491 into microsoft:master Nov 21, 2019
@corinagum corinagum deleted the feat-redux-hooks-8 branch November 21, 2019 21:45
@corinagum corinagum added the R7 label Dec 3, 2019
@compulim compulim mentioned this pull request Dec 10, 2019
73 tasks
@corinagum corinagum mentioned this pull request Dec 13, 2019
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move to Redux Hooks

4 participants