Skip to content

Add React hooks for customization (part 4)#2543

Merged
compulim merged 39 commits intomicrosoft:masterfrom
compulim:feat-redux-hooks-4
Nov 14, 2019
Merged

Add React hooks for customization (part 4)#2543
compulim merged 39 commits intomicrosoft:masterfrom
compulim:feat-redux-hooks-4

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Nov 3, 2019 •
edited
Loading

Related to #2539.

Please merge #2540, #2541 and #2542 before reviewing this one.

Note to myself: check test fail if it is related to missing Adaptive Cards Host Config. Also, add a test for customization the host config.

Changelog Entry

  • Resolves #2539, added React hooks for customization, by @compulim and @corinagum, in the following PRs:
    • PR #2540: useActivities, useReferenceGrammarID, useSendBoxDictationStarted
    • PR #2541: useStyleOptions, useStyleSet
    • PR #2542: useLanguage, useLocalize
    • PR #2543: useAdaptiveCardsHostConfig, useAdaptiveCardsPackage, useRenderMarkdownAsHTML
  • Bring your own Adaptive Cards package by specifying adaptiveCardsPackage prop, by @compulim in PR #2543

Description

Add useAdaptiveCardsHostConfig, useAdaptiveCardsPackage and useRenderMarkdownAsHTML.

Specific Changes

  • Added the following hooks:
    • useAdaptiveCardsHostConfig
    • useAdaptiveCardsPackage
    • useRenderMarkdownAsHTML
  • Updated components to use aforementioned hooks
  • Added an entry prop adaptiveCardsPackage for easily specifying custom Adaptive Cards package
  • Testing Added
    • Adds a test custom Adaptive Cards package
    • Adds a test for customizing Adaptive Cards host config

@compulim compulim mentioned this pull request Nov 3, 2019
Merged
1 task
@compulim compulim force-pushed the feat-redux-hooks-4 branch 4 times, most recently from e7b7104 to 564c821 Compare November 3, 2019 23:36
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 3, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 64.211% when pulling 023c4a8 on compulim:feat-redux-hooks-4 into 39f7c70 on microsoft:master.

This was referenced Nov 4, 2019
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@compulim compulim force-pushed the feat-redux-hooks-4 branch 2 times, most recently from 0935963 to bc863e5 Compare November 12, 2019 03:21
tdurnford
tdurnford reviewed Nov 12, 2019
View reviewed changes
Comment thread packages/component/src/Activity/StackedLayout.js Outdated
tdurnford
tdurnford reviewed Nov 12, 2019
View reviewed changes
Comment thread packages/bundle/src/__tests__/createDirectLine.spec.js Outdated
tdurnford
tdurnford reviewed Nov 12, 2019
View reviewed changes
Comment thread packages/bundle/src/adaptiveCards/hooks/useAdaptiveCardsHostConfig.js
tdurnford
tdurnford reviewed Nov 12, 2019
View reviewed changes
Comment thread packages/bundle/src/adaptiveCards/hooks/useAdaptiveCardsPackage.js
tdurnford
tdurnford reviewed Nov 12, 2019
View reviewed changes
Comment thread samples/01.a.getting-started-full-bundle/index.html Outdated
tdurnford
tdurnford reviewed Nov 12, 2019
View reviewed changes
Comment thread samples/01.a.getting-started-full-bundle/index.html Outdated
tdurnford
tdurnford approved these changes Nov 14, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@tdurnford tdurnford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green light

@compulim compulim merged commit db2a1bb into microsoft:master Nov 14, 2019
@corinagum corinagum added the R7 label Dec 3, 2019
@compulim compulim mentioned this pull request Dec 10, 2019
Closed
73 tasks
@corinagum corinagum mentioned this pull request Dec 13, 2019
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdurnford tdurnford tdurnford approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move to Redux Hooks

4 participants

@compulim @coveralls @tdurnford @corinagum