Skip to content

Add React hooks for customization (part 3)#2542

Merged
compulim merged 30 commits intomicrosoft:masterfrom
compulim:feat-redux-hooks-3
Nov 12, 2019
Merged

Add React hooks for customization (part 3)#2542
compulim merged 30 commits intomicrosoft:masterfrom
compulim:feat-redux-hooks-3

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Nov 2, 2019

Related to #2539.

Please merge #2540 and #2541 before reviewing this one.

Changelog Entry

  • Resolves #2539, added React hooks for customization, by @compulim and @corinagum, in the following PRs:
    • PR #2540: useActivities, useReferenceGrammarID, useSendBoxDictationStarted
    • PR #2541: useStyleOptions, useStyleSet
    • PR #2542: useLanguage, useLocalize

Description

Add useLanguage and useLocalize.

Specific Changes

  • Added the following hooks:
    • useLanguage
    • useLocalize
  • Updated components to use aforementioned hooks
  • Testing Added

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 2, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 64.04% when pulling 0b7c65e on compulim:feat-redux-hooks-3 into 6f06879 on microsoft:master.

@compulim compulim marked this pull request as ready for review November 2, 2019 22:01
This was referenced Nov 3, 2019
Merged
Merged
This was referenced Nov 4, 2019
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
corinagum
corinagum reviewed Nov 6, 2019
View reviewed changes
Comment thread samples/01.a.getting-started-full-bundle/index.html Outdated
@compulim compulim force-pushed the feat-redux-hooks-3 branch 2 times, most recently from 19fc067 to 2950ede Compare November 7, 2019 01:42
tdurnford
tdurnford reviewed Nov 7, 2019
View reviewed changes
Comment thread __tests__/hooks/useLanguage.js
tdurnford
tdurnford reviewed Nov 7, 2019
View reviewed changes
Comment thread packages/component/src/Localization/Localize.js
tdurnford
tdurnford reviewed Nov 7, 2019
View reviewed changes
Comment thread packages/component/src/hooks/useLocalizeDate.js
tdurnford
tdurnford approved these changes Nov 7, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@tdurnford tdurnford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

corinagum
corinagum suggested changes Nov 8, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to submit again after deleting some comments

Comment thread HOOKS.md Outdated
Comment thread HOOKS.md Outdated
Comment thread HOOKS.md
@compulim compulim mentioned this pull request Nov 11, 2019
Merged
@compulim compulim merged commit ca2107c into microsoft:master Nov 12, 2019
@compulim compulim deleted the feat-redux-hooks-3 branch November 12, 2019 01:12
@corinagum corinagum added the R7 label Dec 3, 2019
@compulim compulim mentioned this pull request Dec 10, 2019
Closed
73 tasks
@corinagum corinagum mentioned this pull request Dec 13, 2019
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdurnford tdurnford tdurnford approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

+1 more reviewer

@corinagum corinagum corinagum approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move to Redux Hooks

4 participants

@compulim @coveralls @corinagum @tdurnford