Skip to content

Add React hooks for customization (part 2)#2541

Merged
compulim merged 14 commits intomicrosoft:masterfrom
compulim:feat-redux-hooks-2
Nov 7, 2019
Merged

Add React hooks for customization (part 2)#2541
compulim merged 14 commits intomicrosoft:masterfrom
compulim:feat-redux-hooks-2

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Nov 2, 2019 •
edited
Loading

Related to #2539.

Please merge #2540 before reviewing this one.

Changelog Entry

  • Resolves #2539, added React hooks for customization, by @compulim and @corinagum, in the following PRs:
    • PR #2540: useActivities, useReferenceGrammarID, useSendBoxDictationStarted
    • PR #2541: useStyleOptions, useStyleSet

Description

Add useStyleOptions and useStyleSet.

Specific Changes

  • Added the following hooks:
    • useStyleOptions
    • useStyleSet
  • Updated components to use aforementioned hooks
  • Testing Added

@compulim compulim mentioned this pull request Nov 2, 2019
Merged
1 task
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 2, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.6%) to 63.889% when pulling 487a21c on compulim:feat-redux-hooks-2 into c4a5852 on microsoft:master.

@compulim compulim marked this pull request as ready for review November 2, 2019 22:01
This was referenced Nov 3, 2019
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@corinagum
Copy link
Copy Markdown
Contributor

corinagum commented Nov 4, 2019

Could you justify the test behavior changes before we review this PR?

  • Input placeholders behavior is changing
  • Some scrolling behavior is changing

tdurnford
tdurnford reviewed Nov 4, 2019
View reviewed changes
Comment thread HOOKS.md Outdated
tdurnford
tdurnford reviewed Nov 4, 2019
View reviewed changes
Comment thread HOOKS.md Outdated
tdurnford
tdurnford reviewed Nov 4, 2019
View reviewed changes
Comment thread HOOKS.md Outdated
tdurnford
tdurnford reviewed Nov 4, 2019
View reviewed changes
Comment thread HOOKS.md Outdated
Comment thread HOOKS.md Outdated
Comment thread HOOKS.md Outdated
Comment thread HOOKS.md Outdated
Comment thread HOOKS.md Outdated
Comment thread packages/component/src/Activity/StackedLayout.js
Comment thread packages/component/src/Attachment/DownloadAttachment.js
Comment thread packages/component/src/Attachment/TextContent.js
Comment thread packages/component/src/Attachment/UploadAttachment.js
Comment thread packages/component/src/BasicSendBox.js
@compulim compulim merged commit 0889fa0 into microsoft:master Nov 7, 2019
@compulim compulim deleted the feat-redux-hooks-2 branch November 7, 2019 01:54
@corinagum corinagum added the R7 label Dec 3, 2019
@compulim compulim mentioned this pull request Dec 10, 2019
Closed
73 tasks
@corinagum corinagum mentioned this pull request Dec 13, 2019
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdurnford tdurnford tdurnford left review comments

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

+1 more reviewer

@corinagum corinagum corinagum approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move to Redux Hooks

4 participants

@compulim @coveralls @corinagum @tdurnford