Skip to content

Add React hooks for customization (part 1)#2540

Merged
compulim merged 7 commits intomicrosoft:masterfrom
compulim:feat-redux-hooks-1
Nov 7, 2019
Merged

Add React hooks for customization (part 1)#2540
compulim merged 7 commits intomicrosoft:masterfrom
compulim:feat-redux-hooks-1

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Nov 1, 2019

Related to #2539.

Changelog Entry

  • Resolves #2539, added React hooks for customization, by @compulim and @corinagum, in the following PRs:
    • PR #2540: useActivities, useReferenceGrammarID, useSendBoxDictationStarted

Description

Add useActivities, useReferenceGrammarID and useSendBoxDictationStarted.

Specific Changes

  • Test harness
    • Added runHook function
  • Exporting hooks
  • Added the following hooks:
    • useActivities
    • useReferenceGrammarID
    • useSendBoxDictationStarted
  • Updated components to use forementioned hooks
  • Renamed Context to WebChatUIContext
  • Removed unnecessary HOC for <ScreenReaderText>
  • Updated WebChatReduxContext to export custom Redux hooks (this is not publicly exporting)
  • Updated sample 21 to use aforementioned hooks

  • Testing Added

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 2, 2019

Coverage Status

Coverage increased (+0.08%) to 63.407% when pulling 7b56c4c on compulim:feat-redux-hooks-1 into c4a5852 on microsoft:master.

Comment thread __tests__/setup/web/index.html
Comment thread packages/component/src/BasicSendBox.js
Comment thread packages/component/src/hooks/useActivities.js
Copy link
Copy Markdown
Contributor

@tdurnford tdurnford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compulim compulim merged commit ef38aa4 into microsoft:master Nov 7, 2019
@compulim compulim deleted the feat-redux-hooks-1 branch November 7, 2019 01:36
@corinagum corinagum added the R7 label Dec 3, 2019
@compulim compulim mentioned this pull request Dec 10, 2019
73 tasks
@corinagum corinagum mentioned this pull request Dec 13, 2019
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move to Redux Hooks

4 participants