Conversation
corinagum
suggested changes
Oct 23, 2019
corinagum
approved these changes
Oct 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
Description
Emulator is using CSS variable for bubble background.
Today, bubble nub is rendered using SVG in Data URI as background image. This approach will not work with CSS variables.
Tomorrow, we are changing bubble nub to be rendered using pure SVG, thus, it can be styled using CSS properly, e.g.
fill,stroke, andstroke-width.Technical details
background-imageof a CSScolorto normalize the color#F00is not supported, so we need to normalize it to#FF0000colorpackage cannot read CSS variables, that's why it's breakingbackground-imagefill,stroke, andstrokeWidth<svg>, instead of CSS stylebackground-image: data:image/svg+xml;utf8,<svg xmlns="" ...>Specific Changes
src/Activity/Bubble.jsto use SVG to render the bubble nubsrc/Styles/StyleSet/Bubble.jscolorpackage because it is no longer being used