Skip to content

Fix sample 13 for wrong Speech Services region#2482

Merged
corinagum merged 4 commits intomasterfrom
fix-2473
Oct 21, 2019
Merged

Fix sample 13 for wrong Speech Services region#2482
corinagum merged 4 commits intomasterfrom
fix-2473

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Oct 18, 2019

Fixes #2473.

Changelog Entry

Fixed

  • Fix #2473. Fix samples 13 using wrong region for Speech Services credentials, by @compulim in PR #2482

Description

Sample 13 is not working because we recently changed Speech Services region from westus to westus2.

Specific Changes

  • Update fetch token logic to become fetch credentials logic, which include both region and token
  • When initializing, we will use the freshly-fetched region
    • We assume the region will not be changed once it's fetched

  • Testing Added
    • Currently, we don't have tests for samples

@corinagum corinagum merged commit 3cf5d9b into master Oct 21, 2019
@compulim compulim deleted the fix-2473 branch October 22, 2019 18:43
@compulim compulim mentioned this pull request Oct 25, 2019
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Demo 13 'customization-speech-ui' is broken

2 participants