Added speech synthesis bypass engine#2445
Merged
compulim merged 6 commits intomicrosoft:masterfrom Oct 5, 2019
Merged
Conversation
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
tdurnford and
tonyanziano
as code owners
compulim
changed the title
tdurnford
reviewed
Oct 4, 2019
Co-Authored-By: TJ Durnford <[email protected]>
corinagum
reviewed
Oct 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
On a system without speech synthesis engine:
Since speech synthesis is not available, the queued message is pending to be synthesized and never complete. Internally, we will wait until all queued messages are synthesized before turning on the microphone. This is to prevent echo (bot hearing itself talking). Thus, the microphone will get stuck and never turned on.
The speech synthesis engine is configured on the
componentside. When the saga in thecoreside tries to perform synthesis, it has no knowledge whether the engine is available or not.This can be reproduced by:
Since no speech synthesis engine is configured, the bot message is being queued but never complete. And the microphone is queued to open after all synthesis is completed. Thus, the microphone button is disabled and never open.
Specific Changes
If speech synthesis engine is not configured, we will provide a bypass engine.
The bypass engine will act just like the real engine, except all synthesis operation will be completed instantly. This will unblock any future issues related to queued messages on a configured off system.
In the future, we could consider moving all speech operations to
componentside to prevent this issue from happening.