Skip to content

Use thumbnailUrl for thumbnails#2433

Merged
compulim merged 6 commits intomicrosoft:masterfrom
compulim:fix-2422
Oct 1, 2019
Merged

Use thumbnailUrl for thumbnails#2433
compulim merged 6 commits intomicrosoft:masterfrom
compulim:fix-2422

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Sep 30, 2019 •
edited
Loading

Fixes #2422.

Changelog Entry

Changed

  • bundle: Bumped DirectLineJS to support metadata when uploading attachments, in PR #2433
    • [email protected]
    • Removed DirectLineJS as a dev dependency for component because it was not referenced

Fixed

  • Fix #2422. Storing thumbnail URL using attachment.thumbnailUrl field in the activity, by @compulim in PR #2433

Added

  • Render thumbnail for image attachments using activity.attachments[].thumbnailUrl, by @compulim in PR #2433

Description

Today, Web Chat locally build thumbnails and we save the thumbnail using thumbnailUrl.

In Direct Line API, there is a field dedicated for thumbnail, namely, activity.attachments[].thumbnailUrl.

Tomorrow, we will use the thumbnailUrl to upload and render.

Specific Changes

  • Bump to [email protected], which support metadata while uploading attachments
  • Move from channelData.thumbnails to the new thumbnailUrl field
  • Render image attachments using thumbnailUrl if available, fallback to contentUrl
  • Testing Added
    • No new tests are added

tdurnford
tdurnford reviewed Sep 30, 2019
View reviewed changes
Comment thread CHANGELOG.md Outdated
tdurnford
tdurnford approved these changes Sep 30, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@tdurnford tdurnford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 1, 2019

Coverage Status

Coverage decreased (-0.02%) to 67.988% when pulling 5d0cf21 on compulim:fix-2422 into 5164930 on microsoft:master.

@compulim compulim merged commit 903400a into microsoft:master Oct 1, 2019
@compulim compulim deleted the fix-2422 branch October 1, 2019 09:28
@compulim compulim mentioned this pull request Oct 4, 2019
Closed
13 tasks
compulim added a commit to compulim/BotFramework-WebChat that referenced this pull request Oct 5, 2019
@compulim
Use thumbnailUrl for thumbnails (microsoft#2433)
ad9c7b2 
* Use thumbnail URL

* Update PR number

* Update CHANGELOG.md

Co-Authored-By: TJ Durnford <[email protected]>

* Fix ESLint

* Fix ESLint

* Fix ESLint
This was referenced Oct 5, 2019
Closed
Closed
Closed
Merged
@compulim compulim mentioned this pull request Oct 25, 2019
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdurnford tdurnford tdurnford approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use thumbnail URL instead of channel data for storing the thumbnail

3 participants

@compulim @coveralls @tdurnford