Fix saga error should not result in unhandled exception#2421
Merged
compulim merged 1 commit intomicrosoft:masterfrom Oct 29, 2019
Merged
Fix saga error should not result in unhandled exception#2421compulim merged 1 commit intomicrosoft:masterfrom
compulim merged 1 commit intomicrosoft:masterfrom
Conversation
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
tdurnford and
tonyanziano
as code owners
tdurnford
reviewed
Sep 23, 2019
corinagum
suggested changes
Sep 23, 2019
Contributor
Author
Yap, was working on this yesterday. It works on my PC. 🤔 |
compulim
force-pushed
the
fix-2420
branch
2 times, most recently
from
66e1659 to
0271367
Compare
Contributor
|
Ping |
Contributor
|
ping... |
1 similar comment
Contributor
|
ping... |
corinagum
approved these changes
Oct 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
Saga error is currently resulted in unhandled exception. Once that is fixed, it become disconnected, instead of keeping at saga error.
Specific Changes
connectivityStatus.jssagaerrorTesting Added