Language of timestamp should update on-the-fly#2414
Merged
compulim merged 4 commits intomicrosoft:masterfrom Sep 25, 2019
Merged
Language of timestamp should update on-the-fly#2414compulim merged 4 commits intomicrosoft:masterfrom
compulim merged 4 commits intomicrosoft:masterfrom
Conversation
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
tdurnford and
tonyanziano
as code owners
corinagum
approved these changes
Sep 23, 2019
compulim
force-pushed
the
fix-2360
branch
2 times, most recently
from
09f02b3 to
cb81cf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
During our last React function component push, a bug was introduced to the
RelativeTime.js. If language change, the display didn't adopt.Specific Changes
RelativeText.jsupdateProps()function, to introduce changes to the props, so we can modify language after the component is rendered