Added allowFullScreen prop to video content iframes#2399
Merged
tdurnford merged 2 commits intomicrosoft:masterfrom Sep 13, 2019
Merged
Added allowFullScreen prop to video content iframes#2399tdurnford merged 2 commits intomicrosoft:masterfrom
tdurnford merged 2 commits intomicrosoft:masterfrom
Conversation
tdurnford
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten and
tonyanziano
as code owners
compulim
reviewed
Sep 13, 2019
compulim
approved these changes
Sep 13, 2019
Co-Authored-By: William Wong <[email protected]>
This was referenced Oct 25, 2019
corinagum
pushed a commit
that referenced
this pull request
Oct 29, 2019
* Add test for #2331 * Add test for hiding scroll to bottom button * Add test for YouTube full screen control * Reliability * Filter out DIRECT_LINE/CONNECT* actions * Set payload.directLine to empty object * Filter out payload.directLine * Better filtering
73 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2398
Changelog Entry
Added full screen capability to iframes in the
YouTubeContentandVimeoContentcomponents by @tdurnford in PR #2399Description
See Changelog entry