Adding Arabic to localization#2369
Closed
OdaiHatemMOE wants to merge 6 commits intomicrosoft:masterfrom
Closed
Conversation
OdaiHatemMOE
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
tdurnford and
tonyanziano
as code owners
|
|
corinagum
suggested changes
Aug 29, 2019
Contributor
corinagum
left a comment
corinagum
left a comment
There was a problem hiding this comment.
Thank you for the submission! I left a few comments, it would be great if you could address those. We would love to get this PR in. Thanks!
Contributor
|
It looks like the tests are failing because of linting errors. Could you run |
Contributor
|
@OdaiHatemMOE gentle ping, would you be able to take a look at the linting errors? Thank you! |
Contributor
|
This PR is stale, so I am closing this issue. We will implement this in the future with original credit, and tracking can be found at #1976 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changelog Entry
Adding Arabic localization
Description
Adding Arabic localization
Specific Changes
Adding ar-AR.js to localization