Add option to select voice#2338
Merged
compulim merged 11 commits intomicrosoft:masterfrom Aug 23, 2019
Merged
Conversation
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
tdurnford and
tonyanziano
as code owners
corinagum
approved these changes
Aug 21, 2019
Contributor
corinagum
left a comment
corinagum
left a comment
There was a problem hiding this comment.
Approved pending edits, but please wait until the 'Hooked' App.js is in! After that your App.js changes will need to be updated xD
compulim
changed the title
compulim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2292.
Changelog Entry
Added
selectVoice(), by @compulim, in PR #2338Samples
Description
Add an option to select speech synthesis voice based on activity.
Specific Changes
selectVoice(voices: SpeechSynthesisVoice[], activity: Activityto select voice based on activity