Updating submitSendBoxSaga.js to send sendBoxValue.trim()#2331
Updating submitSendBoxSaga.js to send sendBoxValue.trim()#2331tdurnford merged 10 commits intomicrosoft:masterfrom
Conversation
Suggested fix by tdurnford for issue microsoft#2330 Trimming sendBoxValue on enter key submit
jimmyjames177414
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten and
tonyanziano
as code owners
|
@jimmyjames177414 Can you also update the |
jimmyjames177414
changed the title
|
|
|
Sounds great, I'll get right on it! Thank you for the opportunity! |
Removing incorrect reference to minor patch in the CHANGELOG.md
|
@jimmyjames177414 Can you also remove |
|
@tdurnford yep! I'll get right on it! |
Removing setSendBox(sendBoxValue.trim()) from SendButton.js
Removing setSendBox(sendBoxValue.trim()) from TextBox.js
Implementing @tdurnford's refactoring request for SendButton.js: -Removing setSendBox and sendBoxValue from function declaration since it is no longer used. -Since we are only making one function call in the click method, we are removing it and passing submitSendBox to the button's onClick handler.
|
@jimmyjames177414, thanks for your hard work so far. :) Just FYI, the CI is failing because there are linting errors. you can run the command Once these are fixed we can see if any tests are failing. Let us know if you have questions. |
Correcting Lint errors in SendButton.js
|
Looks good to me! Thanks again for your help @jimmyjames177414! The Web Chat team really appreciates your contributions. If you are interested in contributing more, I highly recommend you take a look at our issues labeled "Help wanted" and "Good first bug". |
|
Woo hoo! |
* Add test for #2331 * Add test for hiding scroll to bottom button * Add test for YouTube full screen control * Reliability * Filter out DIRECT_LINE/CONNECT* actions * Set payload.directLine to empty object * Filter out payload.directLine * Better filtering
5 participants
Suggested fix by @tdurnford for issue #2328
Sending questions with trailing spaces using enter fails to trim(). - fix included
Fixes #2328
Changelog Entry
Updating submitSendBoxSaga.js to send sendBoxValue.trim(), by @jimmyjames177414 in PR #2331
Description
Sending questions with trailing spaces using enter fails to trim(). - fix included