Moved Typing Indicator to SendBox#2321
Merged
corinagum merged 11 commits intomicrosoft:masterfrom Aug 19, 2019
Merged
Conversation
tdurnford
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten and
tonyanziano
as code owners
corinagum
reviewed
Aug 16, 2019
| - `component`: Remove [`react`](https://www.npmjs.com/package/react) and [`react-dom`](https://www.npmjs.com/package/react-dom) from `devDependencies` | ||
| - `playground`: Remove [`react`](https://www.npmjs.com/package/react) and [`react-dom`](https://www.npmjs.com/package/react-dom) from `dependencies` | ||
| - `samples/*`: Move to production version of Web Chat, and bump to [`[email protected]`](https://www.npmjs.com/package/react) and [`[email protected]`](https://www.npmjs.com/package/react-dom) | ||
| - Moved the typing indicator to the send box and removed the typing indicator logic from the sagas, by [@tdunrford](https://github.com/tdurnford), in PR [#2321](https://github.com/microsoft/BotFramework-WebChat/pull/2321) |
Contributor
There was a problem hiding this comment.
spelling OF YOUR OWN USERNAME xP
Contributor
Author
There was a problem hiding this comment.
Surprised prettier didn't catch that
compulim
approved these changes
Aug 16, 2019
Contributor
compulim
left a comment
compulim
left a comment
There was a problem hiding this comment.
I really love this work.
Simplifying so much code while enabling the user. IMO, this is the most enjoyable part of refactoring/rewriting work.
The direction is great, and I think you will work on the comment. So I am approving this. Feel free to re-request review if big things come up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2214
Fixes #2031
Changelog Entry
Moved the typing indicator to the send box and removed the typing indicator logic from the sagas, by @tdurnford, in PR #2321
Description
Removed typing indicator from the conversation transcript and added it to the
SendBox.Specific Changes
lastTypingAtreducer that updates on typing activities.TypingActivitycomponent and createdTypingIndicatorcomponent.typingAnimationDurationto the default style options.....