Fixed Adaptive Cards not speaking#2320
Merged
corinagum merged 3 commits intomicrosoft:masterfrom Aug 15, 2019
Merged
Conversation
corinagum
approved these changes
Aug 15, 2019
tdurnford
requested review from
a-b-r-o-w-n,
compulim,
cwhitten and
tonyanziano
as code owners
73 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2243
Changelog Entry
Fix #2243. Fixed sagas to correctly mark activities with speaking attachments, by @tdurnford in PR #2320
Description
The
speakActivityAndStartDictateOnIncomingActivityFromOthersSagasaga was not correctly marking activities with speaking attachments as speaking activities. Updating the if statement to check incoming activities' attachments for thespeakproperty resolves the issue.