Skip to content

Add ES5 polyfills and dev server to embed page#2315

Merged
compulim merged 5 commits intomicrosoft:masterfrom
compulim:feat-embed-es5
Aug 16, 2019
Merged

Add ES5 polyfills and dev server to embed page#2315
compulim merged 5 commits intomicrosoft:masterfrom
compulim:feat-embed-es5

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Aug 14, 2019

Changelog Entry

Added

  • embed: Added ES5 polyfills and dev server, by @compulim, in PR #2315

Description

Today, embed page is not supported under IE11 due to missing of ES5 polyfills.

We are adding ES5 polyfills to the embed page so it will run smoothly under IE11.

We are also adding dev server to host the embed page locally, without using Fiddler.

Specific Changes

  • Add core-js, url-search-params-polyfill, and whatwg-fetch to the embed page
  • Add restify et al. for the dev server
    • Will fetch token from MockBot if not specified

  • Testing Added

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 14, 2019

Coverage Status

Coverage remained the same at 66.114% when pulling 32ae047 on compulim:feat-embed-es5 into eaa1d22 on microsoft:master.

@compulim compulim merged commit c39905c into microsoft:master Aug 16, 2019
@compulim compulim mentioned this pull request Oct 25, 2019
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants