Ignore speech synthesis errors#2300
Merged
compulim merged 5 commits intomicrosoft:masterfrom Aug 13, 2019
Merged
Conversation
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten and
tonyanziano
as code owners
Co-Authored-By: Corina <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2298.
Changelog Entry
Fixed
Description
Today, when speech synthesis errors occurred, it blocks any other synthesis and recognition operations.
We should ignore synthesis errors to unblock other operations.
Specific Changes
Speak.js, mark the speaking utterance as completed to unblock other operations