Skip to content

Added timestampFormat to default style options#2295

Merged
tdurnford merged 16 commits intomicrosoft:masterfrom
tdurnford:2217
Aug 15, 2019
Merged

Added timestampFormat to default style options#2295
tdurnford merged 16 commits intomicrosoft:masterfrom
tdurnford:2217

Conversation

@tdurnford
Copy link
Copy Markdown
Contributor

@tdurnford tdurnford commented Aug 9, 2019 •
edited
Loading

Fixes #2217

Changelog Entry

Added timestampConfig option to the default style options, by @tdurnford, in PR #2295

Description

Added timestampConfig to the default style options. The developer can toggle the option between 'relative' and 'absolute' - the default is 'relative'.

Specific Changes

Created an AbsoluteTime component and added the ability to switch between absolute and relative time.

basic-js-absolute-timestamp-1-snap

  • Testing Added

@compulim
Copy link
Copy Markdown
Contributor

compulim commented Aug 9, 2019

ESLint failed, easy to fix:

botframework-webchat-component: /home/vsts/work/1/s/packages/component/src/Utils/AbsoluteTime.js
botframework-webchat-component:   14:5  error  Prefer React.Fragment over fragment shorthand  react/jsx-fragments

After ESLint succeeded, it will run npm test. It didn't run any tests right now, so, embrace for the test result!

@tdurnford tdurnford marked this pull request as ready for review August 12, 2019 16:25
corinagum
corinagum reviewed Aug 12, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @compulim will approve

Comment thread CHANGELOG.md Outdated
compulim
compulim approved these changes Aug 13, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking. 😜

Comment thread __tests__/basic.js Outdated
Comment thread __tests__/setup/web/index.html Outdated
Comment thread __tests__/setup/web/index.html Outdated
Comment thread __tests__/basic.js
Comment thread packages/component/src/Activity/Timestamp.js
Comment thread packages/component/src/Activity/Timestamp.js Outdated
Comment thread packages/component/src/Styles/defaultStyleOptions.js Outdated
@tdurnford tdurnford changed the title Added timestampConfig to default style options Added timestampFormat to default style options Aug 14, 2019
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 14, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 66.194% when pulling f0e77be on tdurnford:2217 into 0ebc227 on microsoft:master.

@tdurnford tdurnford merged commit 892e56e into microsoft:master Aug 15, 2019
@compulim compulim mentioned this pull request Aug 22, 2019
Closed
@compulim compulim mentioned this pull request Oct 25, 2019
Closed
55 tasks
@corinagum corinagum mentioned this pull request Nov 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

+1 more reviewer

@corinagum corinagum corinagum approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace relative time with absolute time

4 participants

@tdurnford @compulim @coveralls @corinagum