Add ScreenReaderText component #2278
Merged
corinagum merged 5 commits intomicrosoft:masterfrom Aug 7, 2019
Merged
Conversation
corinagum
requested review from
a-b-r-o-w-n,
compulim,
cwhitten and
tonyanziano
as code owners
compulim
approved these changes
Aug 6, 2019
Contributor
compulim
left a comment
compulim
left a comment
There was a problem hiding this comment.
Nitpicking, it looks good.
Contributor
|
Cross-browser accessibility work is much more harder than cross-browser compatibility work. Good to see how you managed it. |
compulim
approved these changes
Aug 7, 2019
Contributor
compulim
left a comment
compulim
left a comment
There was a problem hiding this comment.
Looks good to me, again!
compulim
pushed a commit
that referenced
this pull request
Aug 7, 2019
* Create component ScreenReaderText * Update CHANGELOG.md * PR cleanup * PR cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2273
Changelog Entry
Description
Narrator and NVDA were unable to examine the transcript of Web Chat in scan mode. These fixes re-enable scan mode with AT.
Specific Changes
<TimeAgo>to<RelativeTime>flat()fromAdaptiveCardRenderer.jsScreenReaderTextcomponent, which adds<span>with text applied toaria-labeland the innerHTML, which allows for reading the text both in readout mode and scan mode.Testing Added