Remove download links from user-uploaded attachments without thumbnails#2262
Merged
compulim merged 6 commits intomicrosoft:masterfrom Aug 6, 2019
Merged
Remove download links from user-uploaded attachments without thumbnails#2262compulim merged 6 commits intomicrosoft:masterfrom
compulim merged 6 commits intomicrosoft:masterfrom
Conversation
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten and
tonyanziano
as code owners
Contributor
|
We probably need tests. Should all current tests be passing right now? |
Contributor
Author
|
Should wait until #2206 is merged. |
Closed
|
Hi, What is the solution for this to work? i am using the latest webchat.js in my web chat and still i see the download icon for the uploaded documents. Can anyone provide me some help here. enableUploadThumbnail is set to false. Do i have to add anything else to style options or am i missing something here? |
Contributor
|
If you need these changes immediately, please see our documentation on pointing to our MyGet feed for latest bits. |
compulim
added a commit
to compulim/BotFramework-WebChat
that referenced
this pull request
Oct 5, 2019
…ls (microsoft#2262) * Add upload attachment renderer * Check thumbnail * Update PR number * Fix propTypes * Fix render error for text attachment * Update non-photo upload PNGs
This was referenced Oct 5, 2019
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2248.
Changelog Entry
Fixed
Description
We disabled links to user-uploaded attachment on our servers. This PR disable the links on the client if the attachment does not have a thumbnail. The thumbnail work is in PR #2206.
It would looks like this:
Specific Changes
UploadAttachmentrenderer, which is very similar toDownloadAttachmentbut without linksUploadAttachmentin the attachment middleware, will use the renderer if the attachment is from user and does not have a thumbnail