Skip to content

#2151 Enhance docs on Authentication#2238

Merged
corinagum merged 4 commits intomicrosoft:masterfrom
corinagum:docs-2151
Jul 30, 2019
Merged

#2151 Enhance docs on Authentication#2238
corinagum merged 4 commits intomicrosoft:masterfrom
corinagum:docs-2151

Conversation

@corinagum
Copy link
Copy Markdown
Contributor

Related to #2151

Changelog Entry

N/A

Description

Web Chat documentation needs to be updated to encourage token API usage.

Specific Changes

Samples now say the following:

 // Your client code must provide either a secret or a token to talk to your bot.
 // Tokens are more secure. To learn about the differences between secrets and tokens
 // and to understand the risks associated with using secrets, visit https://docs.microsoft.com/en-us/azure/bot-service/rest-api/bot-framework-rest-direct-line-3-0-authentication?view=azure-bot-service-4.0

I have also added verbiage to the root README.md emphasizing our recommendation for token API adoption.

Note: the docs link above will need to be updated once we have a new page with updated Authentication docs. For that reason I will keep #2151 open and monitor.


  • Testing Added

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 30, 2019

Coverage Status

Coverage remained the same at 64.984% when pulling e377611 on corinagum:docs-2151 into 607ba96 on microsoft:master.

Copy link
Copy Markdown
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking.

Just a thought, should we put out warning in console?

Comment thread README.md Outdated
Comment thread README.md
Comment thread README.md Outdated
Comment thread README.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants