Adjust outgoing activity timestamp#2208
Merged
compulim merged 10 commits intomicrosoft:masterfrom Jul 23, 2019
Merged
Conversation
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten and
tonyanziano
as code owners
stevengum
approved these changes
Jul 22, 2019
Contributor
|
@compulim can we get another PR in with the changes I suggested? |
corinagum
reviewed
Jul 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1954.
Changelog Entry
Description
If client clock is skewed significantly behind server clock (client clock < server clock for 5 seconds), the user-originated activity could be appears on top of the transcript momentarily until Direct Line Channel echo back the message with a corrected timestamp.
This is because the timestamp we temporarily assign to the user-originated activity is inaccurate. The insertion-sort put the outgoing activity before other activities received from the server. When server echo back the message, it will correct the timestamp.
This fix is to estimate the clock skew and applies to the outgoing activity.
Specific Changes
postActivity.jschannelData.clientTimestamp, to estimate the clock skew by comparing it withtimestampfieldtimestampfield on outgoing activity, adjust it with the estimated clock skewclockSkewAdjustment.jschannelData.clientTimestampfield