Skip to content

Clear suggested-actions on button click#2190

Merged
corinagum merged 8 commits intomicrosoft:masterfrom
tdurnford:2160
Jul 17, 2019
Merged

Clear suggested-actions on button click#2190
corinagum merged 8 commits intomicrosoft:masterfrom
tdurnford:2160

Conversation

@tdurnford
Copy link
Copy Markdown
Contributor

@tdurnford tdurnford commented Jul 15, 2019

Fixes #2160

Changelog Entry

Fix #2160. Clear suggested-actions after button click, by @tdurnford in PR #2190

Specific Changes

Called the setSuggestedActions function in the suggested action's onClick method to clear the suggested actions bar.


  • Testing Added

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 15, 2019

Coverage Status

Coverage increased (+0.4%) to 63.388% when pulling a64cf4d on tdurnford:2160 into 3bc1b65 on microsoft:master.

Comment thread CHANGELOG.md Outdated
Comment thread __tests__/suggestedActions.js Outdated
Comment thread __tests__/suggestedActions.js Outdated
Comment thread __tests__/suggestedActions.js Outdated
Comment thread __tests__/suggestedActions.js Outdated
Comment thread packages/core/src/index.js Outdated
Copy link
Copy Markdown
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for @compulim's input since he had comments previously.

@tdurnford tdurnford requested a review from compulim July 16, 2019 16:52
Copy link
Copy Markdown
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing. 😉

Comment thread packages/core/src/actions/clearSuggestedActions.js Outdated
@corinagum
Copy link
Copy Markdown
Contributor

corinagum commented Jul 16, 2019

rebuilding due to timeout (sorry I hit close on accident :( :( :( )

@corinagum corinagum closed this Jul 16, 2019
@corinagum corinagum reopened this Jul 16, 2019
@corinagum corinagum merged commit 84d194b into microsoft:master Jul 17, 2019
@compulim compulim mentioned this pull request Oct 25, 2019
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking on suggested actions "openurl" button won't close the suggested actions bar

4 participants