Respect "expectingInput" in "inputHint"#2149
Merged
compulim merged 19 commits intomicrosoft:masterfrom Jul 9, 2019
Merged
Conversation
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
corinagum
reviewed
Jul 8, 2019
Contributor
corinagum
left a comment
corinagum
left a comment
There was a problem hiding this comment.
Pending some comments.
corinagum
approved these changes
Jul 8, 2019
Contributor
corinagum
left a comment
corinagum
left a comment
There was a problem hiding this comment.
Hit the wrong radio, sorry. Please verify comments before merging
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2022.
Changelog Entry
"expectingInput"ininputHintis not respected, by @compulim and @corinagum in PR #2149Description
Added code to handle
"expectingInput"ininputHint.Also tested against permutations of
expectingInput,acceptingInput, andignoringInputin consecutive cases:expectingInputwill record on the microphone regardless if the last message was recorded from the microphone or notacceptingInputwill record on microphone only if the last message was recorded from the microphoneignoringInputwill stop the microphone, even if it is turned onSpecific Changes
Dictation.jsis modified in a way that it will never record on microphone if they are any incoming activities (from the bot) is pending in the queue to speak[ ] Testing Added