Fix observeOnce to unsubscribe properly#2140
Merged
compulim merged 4 commits intomicrosoft:masterfrom Jul 4, 2019
Merged
Conversation
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
corinagum
reviewed
Jul 3, 2019
| () => | ||
| new Promise((resolve, reject) => { | ||
| observable.subscribe(resolve, reject); | ||
| subscription = observable.subscribe(resolve, reject, resolve); |
Contributor
There was a problem hiding this comment.
Can you explain why next and complete are the same? to me it seems like this would make resolve be called twice. :/
Contributor
Author
There was a problem hiding this comment.
observeOnce is essentially converting a stream into an async binary operation (success or fail in async fashion, more-or-less Promise).
For "complete without any results", I think it should be considered as "positive with result of undefined".
corinagum
approved these changes
Jul 3, 2019
Contributor
corinagum
left a comment
corinagum
left a comment
There was a problem hiding this comment.
Approved, but it looks like build is failing. I also asked a question for knowledge purposes, not as constructive criticism xD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1872.
Changelog Entry
observeOnceto unsubscribe properly, by @compulim in PR #2140Description
Our
observeOncesaga effect does not unsubscribe itself from the observable. New code added to unsubscribe after firstonNext,onError, oronCompleted.Specific Changes
Modified
packages/core/src/sagas/effects/observeOnce.jsto unsubscribe regardless of conditions.