Added richCardsWrapTitle to defaultStyleOptions#2115
Added richCardsWrapTitle to defaultStyleOptions#2115corinagum merged 12 commits intomicrosoft:masterfrom
Conversation
tdurnford
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
|
Let's get a test on this one :) |
compulim
left a comment
compulim
left a comment
There was a problem hiding this comment.
Although I agree we should wrap the title, ellipsis looks too ugly today, are there any user asks for this?
I think wrapping the title will make the rich card looks pretty. Should we turn this on by default despite it is a breaking change?
Also, keep in mind that we want to move rich card away from Adaptive Card due to layout problems, enable rich card in minimal bundle, and enable more styling options for rich card.
|
The Support Team has seen an increase in issues regarding the title not wrapping, especially around QnA Prompting. I believe the SDK is mapping the prompts to Hero Cards and is adding the text response as the card's title. More often than not, the text is too long and gets truncated. We've been telling clients to either move the title to the card's text attribute or map the QnA prompt to an Adaptive Card themselves. I'm torn on wrapping the title by default. I think it might be better to wait until we move Rich Cards away from using the Adaptive Card builder. |
|
After discussing offline:
|
3 participants
Fixes #2046
Changelog Entry
Added richCardsWrapTitle to defaultStyleOptions, by @tdurnford, in PR #2115
Specific Changes
Added richCardsWrapTitle to defaultStyleOptions and added styleOptions as a parameter to the AdaptiveCardsBuilder and as a prop for the CommonCard component. Developers should be able to wrap the title attribute in Rich Cards by setting richCardsWrapTitle in styleOptions to true.