Fix scroll stickiness issue with Adaptive Card and suggested actions#2107
Merged
corinagum merged 3 commits intomicrosoft:masterfrom Jun 23, 2019
Merged
Conversation
Contributor
Author
|
@corinagum I added a new WebDriver condition named await driver.wait(scrollToBottomCompleted(), timeouts.scrollToBottom); |
compulim
requested review from
a-b-r-o-w-n,
cwhitten,
justinwilaby and
tonyanziano
as code owners
compulim
force-pushed
the
bump-react-scroll-to-bottom
branch
from
d511c23 to
4b93f2a
Compare
Contributor
|
@tdurnford, do we want to implement the new scrollToBottomCompleted into any of our previous tests? |
Contributor
|
Yea we probably want to update this line to use the new scrollToBottom timeout instead of making the driver sleep for a second. |
corinagum
approved these changes
Jun 23, 2019
Contributor
|
@tdurnford please either file an issue or submit a PR :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1926.
Changelog Entry
Description
Bringing 2 commits from
react-scroll-to-bottom:scrollevents crafted by Chrome should not cause stickiness to loseSpecific Changes
Bumped
react-scroll-to-bottomto1.3.2.