Fixed markdown not rendering in cards#2063
Merged
corinagum merged 7 commits intomicrosoft:masterfrom Jun 10, 2019
Merged
Conversation
tdurnford
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
Contributor
|
Hey did you run |
corinagum
suggested changes
Jun 7, 2019
Contributor
corinagum
left a comment
corinagum
left a comment
There was a problem hiding this comment.
We should probably get tests verifying this scenario too.
Contributor
Author
|
I did run eslint, but I'll double check. I'll do a MockBot PR to add a test as well. |
compulim
approved these changes
Jun 10, 2019
corinagum
approved these changes
Jun 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2062
Changelog Entry
Fix #2062. Fixed markdown not rendering in cards, by @tdurnford in PR #2063
Specific Changes
Added the markdown renderer as a parameter to the createAdaptiveCardsAttachmentMiddleware so it will get passed as a prop to the attachmentMiddleware.
Add test